Fix competitive idle map rotation#1684
Merged
Rainyan merged 1 commit intoNeotokyoRebuild:masterfrom Feb 14, 2026
Merged
Conversation
Fix a bug with the idle map cycle cvar "mp_mapcycle_empty_timeout_seconds" combined with "sv_neo_comp 1" causing an infinitely failing map change loop, where the idle mapchange logic and the sv_neo_readyup logic are fighting each other and flipping the m_bChangelevelDone value back and forth. This commit simply introduces a new "m_bRotatingMapRightNow" state flag for the idle rotation special case to sidestep the problem instead of refactoring the logic. Could be cleaned up in some future refactor...
DESTROYGIRL
approved these changes
Feb 14, 2026
Agiel
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug with the idle map cycle cvar
mp_mapcycle_empty_timeout_secondscombined with cvar valuesv_neo_comp 1causing an infinitely failing map change loop, where the idle mapchange logic and thesv_neo_readyup_...logic are fighting each other, and endlessly flipping them_bChangelevelDonegamerules value back and forth.This commit simply introduces a new
m_bRotatingMapRightNowgamerules state flag for the idle rotation special case to sidestep the problem, instead of refactoring the logic. But it should be good enough to get this problem fixed for now. Could be cleaned up in some future refactor...Steps to reproduce the bug:
Toolchain
Linked Issues