feature/CSTACKEX-65: Aggregate selection logic for creating ONTAP Volume in StoragePool creation workflow #24
+53
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NTAP Volume creation
sandeeplocharla
requested review from
piyush5netapp,
rajiv-jain-netapp and
suryag1201
rajiv-jain-netapp
requested changes
Jan 12, 2026
| throw new CloudRuntimeException("No aggregates are assigned to SVM " + svmName); | ||
| } | ||
| // Set the aggregates which are according to the storage requirements | ||
| int maxAvailableAggregateSpace = storage.getSize().intValue(); |
There was a problem hiding this comment.
Since size isn’t assigned before connect executes, the process cannot succeed.
Collaborator
Author
There was a problem hiding this comment.
Storage is already assigned but the other comment makes sense, aggregate selection should be in Volume creation code. So, have modified the code accordingly
There was a problem hiding this comment.
Let’s go over the code in the scrum meeting. My review was limited to the merged changes and the code review raised, so I’d appreciate your input on the code as it appears in your IDE.
| // Set the aggregates which are according to the storage requirements | ||
| int maxAvailableAggregateSpace = storage.getSize().intValue(); | ||
| Aggregate aggrChosen = null; | ||
| for (Aggregate aggr : aggrs) { |
There was a problem hiding this comment.
Why does the connect method handle aggregate selection? This logic should ideally reside in the volume creation process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Has changes to choose an aggregate based on the max available space while creating ontap volume for Primary StoragePool creation.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Test-1: With Default aggregate sizes in 2vSim ONTAP Cluster
Test-2: After expanding one aggr's size