generated from ellisonleao/nvim-plugin-template
-
-
Notifications
You must be signed in to change notification settings - Fork 39
Add diff viewing #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chuan2984
wants to merge
8
commits into
NickvanDyke:main
Choose a base branch
from
chuan2984:add_diff_viewing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add diff viewing #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuan2984
commented
Dec 1, 2025
| @@ -0,0 +1,14 @@ | |||
| -- Debug helper: Add this to your Neovim config temporarily to see ALL opencode events | |||
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: ignore this file, only for debugging, will be removed
4684c3a to
1c8f8f0
Compare
Owner
I didn't test this super extensively, especially with new providers. lmk if you find a cause or fix along the way! |
3001781 to
cafdc6f
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add PR-style diff review UI for
opencodechanges.This is my rough draft based on some discussion here. I'll be honest and that the
session_diff.luawas mostly AI coded, but was verified and checked for accuracy.Please pull it if you are interested, its been working well for me so far
Key Points
message.updatedevent (contains only current cycle diffs, unlikesession.diffwhichaccumulates everything) for capturing the
before, andafterfor only files touched in the current cycle.vim.diff()unified viewpr reviewstyle enhanced diff view that works withhunk stagingnote:
DiffView.nvimsadly does not really support what we want, since it only works with git rev not local temp files(we are not usinggit, we dont get much fromDiffView.nvimother than the nice UIScreenshot of enhanced diff
Files
lua/opencode/diff.lua- Core review logicplugin/events/session_diff.lua- Event listenerDIFF_FEATURE.md- Full documentationTODOs
planmode should show diff but non-editableBugs
Nice to have?