Use user default language by reply instead of forum default language#120
Open
GermanBluefox wants to merge 1 commit intoNodeBB:masterfrom
Open
Use user default language by reply instead of forum default language#120GermanBluefox wants to merge 1 commit intoNodeBB:masterfrom
GermanBluefox wants to merge 1 commit intoNodeBB:masterfrom
Conversation
We have users with 4 different languages: de, en, nl and ru. Mostly the users with one language communicates to 98% only with the users of the same language. Default forum language is english because the first emails should be in English too. But russian, nl and german users have now "said in" in the responses. My PR will fix this problem and to 98% the answers will be valid. May be it would be interesting to use the language of the quoted user, but this could be solved too if you mean so.
julianlam
approved these changes
Feb 11, 2019
Member
julianlam
left a comment
julianlam
left a comment
There was a problem hiding this comment.
LGTM but I'd like @barisusakli to confirm as well, thanks
Member
|
@pitaj @barisusakli Perhaps we can make this a toggleable option in composer-default |
|
@julianlam That would be nice |
Author
|
Any news on this PR? |
Contributor
|
If we're going to fix the problem of the string not being translated correctly, it should be fixed in a way that works for everyone. This could be done by embedding something like And parsing it into the translation token after parse.post Alternatively, we could make it so the translator always returns safe HTML, and then we'd be able to just embed the translator token directly in the post after enabling translation of post bodies |
Author
|
@pitaj nice to know. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have users with 4 different languages: de, en, nl and ru.
Mostly the users with one language communicates to 98% only with the users of the same language.
Default forum language is english because the first emails should be in English too.
But russian, nl and german users have now "said in" in the responses.
My PR will fix this problem and to 98% the answers will be valid.
May be it would be interesting to use the language of the quoted user, but this could be solved too if you mean so.