feat: self-host MapLibre sprite sheet with Arma 3 icons #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace dead CDN sprite URL (styles.ocap2.com) with self-hosted sprite files generated during the maptool pipeline. Icons are extracted from Arma 3's ui_f_data.pbo (Map/MapControl + Map/LocationTypes) and embedded via go:embed. - Add sprite.go with 27 embedded PNG icons and sprite sheet generator - Generate sprite.json, sprite.png, sprite@2x.json, sprite@2x.png in styles/ directory during generate_styles pipeline stage - Use absolute sprite URL path (e.g. images/maps/altis/styles/sprite) served by existing /images/maps/* route - Disable vegetation layers (tree, bush, vegetation*) in all style variants to reduce visual clutter - Add golang.org/x/image/draw dependency for bilinear icon scaling
Integrate self-hosted sprites with main's new style variants (topo, topo-dark, color-relief), self-hosted glyphs, and GlyphsURL config. Both sprite and glyph URLs are now self-hosted.
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
styles.ocap2.com) with self-hosted sprite files generated during the maptool pipelineui_f_data.pbo) viago:embed, replacing placeholder geometric shapesChanges
internal/maptool/sprite.go— new file: loads embedded PNGs, packs into sprite sheet (1x + 2x), writes JSON manifestinternal/maptool/icons/*.png— 27 icons from Arma 3'sMap/MapControl/andMap/LocationTypes/internal/maptool/styles.go— replace CDN URL with path-based sprite URL viaSpritePrefix; disable vegetation in all variants; recategorize tree/bush as vegetationinternal/maptool/metadata.go— callWriteSpriteFiles()ingenerate_stylesstage; computeSpritePrefixinternal/maptool/sprite_test.go— tests for sprite generation, file writing, and icon↔style cross-referencego.mod— addgolang.org/x/imagefor bilinear scalingTest plan
go test ./internal/maptool/...passesstyles/directory