core/scheduler: fix builder registration unmarshalling

[DiogoSantoss]

Fix builder registration unmarshalling

category: bug
ticket: none

[codecov]

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.30%. Comparing base (403a664) to head (23d12ba).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
app/app.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4183      +/-   ##
==========================================
+ Coverage   56.27%   56.30%   +0.02%     
==========================================
  Files         245      245              
  Lines       31288    31286       -2     
==========================================
+ Hits        17607    17615       +8     
+ Misses      11364    11356       -8     
+ Partials     2317     2315       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR fixes a critical bug in builder registration unmarshalling. The builder registrations stored in the cluster manifest are serialized as eth2api.VersionedSignedValidatorRegistration JSON, but the code was incorrectly attempting to unmarshal them into cluster.BuilderRegistration and then convert them. This fix removes the unnecessary conversion layer and uses the correct type throughout the scheduler and testing code.

Key changes:

• Changed scheduler to accept *eth2api.VersionedSignedValidatorRegistration directly instead of cluster.BuilderRegistration
• Removed conversion logic from scheduler.New() that was translating between incompatible types
• Updated test data and helper functions to use proper eth2 API types with fixed-size byte arrays

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
testutil/beaconmock/options.go	Updated BuilderRegistrationSetA to use *eth2api.VersionedSignedValidatorRegistration and added helper functions for creating fixed-size byte arrays
core/scheduler/scheduler_test.go	Updated test to use new type and corrected field access paths (.V1.Message instead of .Message)
core/scheduler/scheduler.go	Changed function signatures to accept *eth2api.VersionedSignedValidatorRegistration and removed incorrect type conversion logic
app/app.go	Updated to unmarshal directly into eth2api.VersionedSignedValidatorRegistration instead of cluster.BuilderRegistration

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud