[typescript-angular] Fix inner enum reference in multi-map property type #22748
+61
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22747
This PR fixes an issue where TypeScript Angular code generation produces invalid InnerEnum type references for map properties containing arrays of inline enums.
Solution:
Added
postProcessModelProperty()override inTypeScriptAngularClientCodegenthat:datatypeWithEnumwith the correctproperty.enumNamepostProcessModels()inAbstractTypeScriptClientCodegenadd the classname prefixTesting:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@TiFu
Summary by cubic
Fixes invalid inner enum references in the TypeScript Angular generator when a map property contains arrays of inline enums. Models now use the correct enum name and compile cleanly. Fixes #22747.
Written for commit b112c18. Summary will update on new commits.