Skip to content

Conversation

@saxicek
Copy link

@saxicek saxicek commented Jan 20, 2026

Fixes #22747

This PR fixes an issue where TypeScript Angular code generation produces invalid InnerEnum type references for map properties containing arrays of inline enums.

Solution:
Added postProcessModelProperty() override in TypeScriptAngularClientCodegen that:

  1. Detects inner enum properties with map/array containers
  2. Finds the innermost item and its incorrectly assigned enum name
  3. Replaces the wrong enum name in datatypeWithEnum with the correct property.enumName
  4. Lets the existing postProcessModels() in AbstractTypeScriptClientCodegen add the classname prefix

Testing:

  • Added new unit test using existing test resource issue_19393_map_of_inner_enum.yaml
  • All 22 existing TypeScript Angular tests pass
  • Manually verified generated code compiles correctly with the fix

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @TiFu

Summary by cubic

Fixes invalid inner enum references in the TypeScript Angular generator when a map property contains arrays of inline enums. Models now use the correct enum name and compile cleanly. Fixes #22747.

  • Bug Fixes
    • Override postProcessModelProperty to detect map/array inner enums and replace the wrong inner enum name with property.enumName. The classname prefix is added by existing postProcessModels logic.
    • Add a unit test (issue_19393_map_of_inner_enum.yaml) to verify the generated type uses the qualified enum name (not InnerEnum). All existing TypeScript Angular tests pass.

Written for commit b112c18. Summary will update on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][typescript-angular] Map with array/set of inner enums generates invalid InnerEnum type reference

1 participant