docfix/fixed tests and added documents #2646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Migration from Akka to Apache Pekko 1.1.2 ## Key Changes: ### Dependency Migration: - Replaced Akka 2.6.20 with Apache Pekko 1.1.2 - Updated all imports from com.typesafe.akka to org.apache.pekko - Updated Jetty from 9.4.50 to 9.4.58 for better Java 17 compatibility ### Actor System Architecture: - Migrated all actor systems to Pekko - Fixed critical scheduler initialization conflicts - Consolidated schedulers to use shared ObpActorSystem.localActorSystem - Prevented multiple actor system creation during boot ### Scheduler Fixes: - DataBaseCleanerScheduler: Fixed actor system reference - DatabaseDriverScheduler: Fixed actor system reference - MetricsArchiveScheduler: Fixed actor system reference - SchedulerUtil: Fixed actor system reference - TransactionRequestStatusScheduler: Fixed actor system reference ### Technical Improvements: - Resolved 'Address already in use' port binding errors - Eliminated ExceptionInInitializerError during boot - Fixed race conditions in actor system initialization - Maintained all scheduler functionality (MUST-have features preserved) ### Files Modified: - Core: pom.xml, obp-api/pom.xml - Actor Systems: ObpActorConfig.scala, ObpActorSystem.scala, ObpLookupSystem.scala - Connectors: AkkaConnector_vDec2018.scala, CardanoConnector, EthereumConnector - Schedulers: All scheduler classes updated to use shared actor system - Utilities: AkkaHttpClient.scala, DynamicUtil.scala, NewStyle.scala ## Testing: ✅ Application starts successfully on port 8080 ✅ All schedulers operational with shared actor system ✅ Pekko actor system running on dynamically allocated port ✅ No port binding conflicts or initialization errors ✅ HTTP endpoints responding correctly ## Migration Notes: - Akka licensing issues addressed by moving to Apache Pekko - Backward compatibility maintained through Pekko's API compatibility - All existing connector and scheduling functionality preserved - Improved stability and reduced memory footprint
…mple.props.template
Add entry documenting new http4s.host and http4s.port configuration properties added to sample.props.template for controlling obp-http4s-runner bind address.
# Conflicts: # obp-api/src/test/resources/frozen_type_meta_data
# Conflicts: # pom.xml
- Update WebUiPropsTest to assert empty body as JNothing instead of "{}"
- Change response body assertion to use `shouldBe(JNothing)` for proper HTTP 204 handling
- Remove default "{}" placeholder in SendServerRequests when response body is empty
- Return empty string "" instead of "{}" to correctly represent No Content responses
- Add clarifying comment explaining that HTTP 204 should have empty body, not JSON object
- Align test expectations with proper REST semantics for 204 No Content status code
# Conflicts: # pom.xml
- Update view ID field references from "id" to "view_id" in getAllSystemViews test - Update view ID field references from "id" to "view_id" in getOneSystemView test - Update view ID field references from "id" to "view_id" in getMultipleSystemViews test - Align test assertions with actual API response schema for system views endpoint
# Conflicts: # pom.xml # release_notes.md
- Bump Jetty version from 9.4.50.v20250814 to 9.4.58.v20250814 - Ensures latest security patches and bug fixes are included - Maintains compatibility with existing HTTP4s and Lift configurations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.