Add UTF-8 and byte strings #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for UTF-8 strings and byte strings in the DSDL specification by updating documentation and grammar rules. Key changes include:
- Adding a bullet point in the introduction outlining support for UTF-8 strings and byte strings.
- Adding new descriptive entries for UTF-8 octet and byte types in the serializable types documentation.
- Updating reserved identifier lists and grammar rules to accommodate the new primitive types.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| specification/introduction/introduction.tex | Added note about support for UTF-8 and byte strings. |
| specification/dsdl/serializable_types.tex | Added detailed entries for UTF-8 octet and byte types with minor typo. |
| specification/dsdl/grammar.tex | Updated reserved identifiers to include new primitive types. |
| specification/dsdl/grammar.parsimonious | Modified grammar rules to accommodate the new primitive types. |
thirtytwobits
previously approved these changes
May 9, 2025
Member
thirtytwobits
left a comment
thirtytwobits
left a comment
There was a problem hiding this comment.
I approve but I think the copilot suggestion is correct, that there's a misspelling?
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
scottdarch
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
See OpenCyphal/pydsdl#97