Skip to content

fix: update phpcs errors#124

Merged
Morgy93 merged 2 commits intomainfrom
fix-phpcs
Feb 5, 2026
Merged

fix: update phpcs errors#124
Morgy93 merged 2 commits intomainfrom
fix-phpcs

Conversation

@Morgy93
Copy link
Collaborator

@Morgy93 Morgy93 commented Feb 4, 2026

This pull request primarily adds inline PHP CodeSniffer (PHPCS) ignore comments to allow the use of certain shell execution functions (shell_exec, exec, passthru) where they are required for system checks or interactive commands. This ensures that static analysis tools do not flag these usages as security issues, since they are necessary for the application's functionality. Additionally, the PHPStan configuration is updated to include bleeding-edge rules.

Key changes include:

Security and Static Analysis Suppression:

  • Added // phpcs:ignore comments before usages of shell_exec, exec, and passthru in various command and builder classes to suppress security warnings from PHPCS, with justification for each case (e.g., TTY detection, checking external tool versions, interactive watch mode). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

Static Analysis Configuration:

  • Updated phpstan.neon to include bleeding-edge PHPStan rules by referencing bleedingEdge.neon, enhancing static analysis coverage.

@Morgy93 Morgy93 merged commit a19e23d into main Feb 5, 2026
12 checks passed
@Morgy93 Morgy93 deleted the fix-phpcs branch February 5, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants