-
Notifications
You must be signed in to change notification settings - Fork 5
Housekeeping 6 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
vincentbergman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comprehensive migration work! The switch to uv looks promising.
I'll pull this branch and run some local tests before we merge. Will report back with any findings.
A few quick questions:
- Have you been able to run the full test suite locally with uv?
- Any issues with the Docker builds?
Appreciate the effort here 👍
|
Hey @ryanmerolle, looks like the workflow is failing on the packaging step. Could you take a look and fix the CI errors before we proceed with the review? Let us know if you need any help debugging. |
|
Just a heads up - this project uses Please check out the Polylith docs for Python: https://davidvujic.github.io/python-polylith-docs There may be some compatibility considerations when switching from Poetry to uv with this architecture. |
|
Yea the pr was only a draft setup, I should have set it accordingly. I had not tested anything. You approach really feels like the default uv workspaces setup. I have done this before with the following structure: Example tree: IE this may need a larger reorg than I intended, but the results will pay dividends in maintainability. I would also say Claude has a smaller but detailed uv related training set given near every python ai project uses it and its so recent; ie the quality prompt returns are higher. |
|
Thanks for the detailed explanation! You're right - this is a bigger change than initially expected. We'll evaluate this internally first. Since the project is still in early stages, the migration cost is relatively low, but we want to make sure we choose the right approach for the long term. Will get back to you once we've discussed the architecture direction 👍 |
|
I think I have a good approach lined up:
Move components and base to their perspective workspace. From there we should move unit tests for each project into said project I can PR a proposal, but would you want components and/or base directory to exist in each project? |
Addresses #6
uvx migrate-to-uvto migrate eachpyproject.tomlpyproject.tomlI heavily used Claude to prepare this. I need to test and validate in the coming days. Feel free to checkout the branch and test.