feat(app): add go back function to protocol visualization page #19941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add go back function to protocol visualization page close AUTH-2437
There was a problem hiding this comment.
Pull Request Overview
This PR adds navigation handling to the Protocol Visualization page to address an edge case where users attempt to access protocol visualization from the protocol setup page when re-running a protocol that doesn't exist in the app. When the protocol's analysis data is unavailable, the user is now redirected back to the previous page.
Key changes:
- Added navigation hook to enable programmatic redirection
- Implemented automatic back navigation when protocol analysis is missing
- Updated dependency arrays and null checks for better React compliance
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jerader
reviewed
Oct 31, 2025
|
|
||
| // this is for an edge case | ||
| // a user tries to access the visualization page from the protocol setup page by re-running the protocol | ||
| // this will be fixed in protocol visualization phase 2 |
Collaborator
There was a problem hiding this comment.
aren't we combining phase 1 and phase 2 now? so shouldn't we address this now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
add go back function to protocol visualization page
https://opentrons.slack.com/archives/C09AFFN9N83/p1761245200385029
close AUTH-2437
Test Plan and Hands on Testing
check the app redirects to the protocol setup page when clicking
visualizationbuttonChangelog
Review requests
Risk assessment
low