-
Notifications
You must be signed in to change notification settings - Fork 187
chore(app-shell, app-shell-odd) update electron version to v39 #20117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
koji
wants to merge
3
commits into
edge
Choose a base branch
from
chore_update-electron-39
base: edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #20117 +/- ##
==========================================
- Coverage 56.74% 55.93% -0.82%
==========================================
Files 3649 3650 +1
Lines 303750 308638 +4888
Branches 42725 45135 +2410
==========================================
+ Hits 172377 172638 +261
- Misses 131159 135785 +4626
- Partials 214 215 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
sfoster1
added a commit
to Opentrons/oe-core
that referenced
this pull request
Dec 9, 2025
Required for electron v39 in Opentrons/opentrons#20117
Member
sfoster1
added a commit
to Opentrons/oe-core
that referenced
this pull request
Dec 10, 2025
Required for electron v39 in Opentrons/opentrons#20117
sfoster1
added a commit
to Opentrons/oe-core
that referenced
this pull request
Dec 11, 2025
Required for electron v39 in Opentrons/opentrons#20117
b89c40f to
7b9c71b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
update electron version to v39
close AUTH-2482
Test Plan and Hands on Testing
maybe needed to run the following
Changelog
Review requests
Risk assessment
low