Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Dec 15, 2025

Overview

const def = labwareDefinitions[definitionUri] is undefined so need a guard for that case

close AUTH-2588

Test Plan and Hands on Testing

  1. download the protocol that is attached to the ticket
  2. import the protocol
  3. visualize the protocol
    check there is no white screen error

Changelog

  • add null check

Review requests

Risk assessment

low

const def = labwareDefinitions[definitionUri] is undefined so need a guard for that case

close AUTH-2588
@koji koji requested review from jerader and ncdiehl11 December 15, 2025 20:54
@koji koji marked this pull request as ready for review December 15, 2025 20:54
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.74%. Comparing base (652c8fd) to head (fdd62eb).
⚠️ Report is 1 commits behind head on edge.

Files with missing lines Patch % Lines
...src/utils/constructInvariantContextFromAnalysis.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20384      +/-   ##
==========================================
- Coverage   56.74%   56.74%   -0.01%     
==========================================
  Files        3649     3649              
  Lines      303774   303777       +3     
  Branches    42724    42724              
==========================================
  Hits       172383   172383              
- Misses     131177   131180       +3     
  Partials      214      214              
Flag Coverage Δ
protocol-designer 19.38% <0.00%> (-0.01%) ⬇️
step-generation 5.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...src/utils/constructInvariantContextFromAnalysis.ts 24.39% <0.00%> (-0.46%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants