[Lifecycle Events] add Minecraft instance API

[SpaceWalkerRS]

Adds a simple wrapper class for retrieving the current Minecraft instance. This is useful given that Minecraft::getInstance was only added in one of the 1.3 snapshots.

The class looks as follows:

public class MinecraftInstance {

	public static Minecraft get() {
		return MinecraftAccess.getInstance();
	}
}

Internally this returns the instance if it is available, and otherwise throws an IllegalStateException. The instance is available from the start of the init method until the end of the shutdown method.

[ENDERZOMBI102]

does this include the server?

[SpaceWalkerRS]

does this include the server?

It doesn't. I do want to add it but I am not sure yet exactly how it should look. For example, should such an API just return a MinecraftServer instance, or should there be another method for getting the DedicatedServer instance?

[ENDERZOMBI102]

What about an injected interface with a default static method on MinecraftServer? that way one can "emulate" getInstance().
Same could be done in the client now that i think of it...

[SpaceWalkerRS]

Do those work transitively?

[ENDERZOMBI102]

I think so, but would need to check

[SpaceWalkerRS]

Hmm I wonder how that'll work between versions that already that method vs versions that don't. Like if we add that method to 1.2 and below, it will not be mapped to intermediary (since it's not a MC method), but in 1.3+ it will. So if you compile a mod against 1.2 it will not work in 1.3.

Unless we also inject the interface in 1.3 and above and just give the method a different name (like instance() instead of getInstance())?

[ENDERZOMBI102]

I suggest to start with the assumption that major versions aren't compatible, so the mod would need to be recompiled anyway

[SpaceWalkerRS]

still, preferably I would avoid imposing that through OSL where feasible

[SpaceWalkerRS]

hold on - the injected interface would be useless for this since the instance getter is static