Fix PHP 8.4 deprecation warnings for implicitly nullable parameters#927
Merged
Fix PHP 8.4 deprecation warnings for implicitly nullable parameters#927
Conversation
This was referenced Apr 30, 2025
Geolim4
approved these changes
Apr 30, 2025
Member
|
Ignore Travis fails as Travis has to be removed asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes the PHP 8.4 deprecation warnings related to implicitly nullable parameters. In PHP 8.4, parameters with a default value of null must be explicitly marked as nullable using the '?' prefix.
Fixes #924 and #926
Changes:
These changes ensure compatibility with PHP 8.4 while maintaining backward compatibility with PHP 8.0+.
Types of changes
What types of changes does your code introduce to Phpfastcache?
Put an
xin the boxes that applyAgreement
I have read the CONTRIBUTING and CODING GUIDELINE docs
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...