[fix] Exclude POSIX special files from inventory#275
Merged
paul-fresquet merged 5 commits intomasterfrom Feb 7, 2026
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates inventory building to exclude POSIX special files/directories (e.g., FIFO, block devices) from generated inventories, while still tracking them as skipped entries and avoiding marking inventory parts as incomplete due to access.
Changes:
- Stop emitting inaccessible
FileDescriptions for POSIX special files; instead record aSkippedEntrywithSkipReason.SpecialPosixFileand log a warning. - Add/adjust unit and integration tests to assert POSIX special entries are excluded from inventories and properly recorded as skipped.
- Add warning logging for POSIX special directories when encountered during directory analysis.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/ByteSync.Client.UnitTests/Services/Inventories/InventoryBuilderInspectorTests.cs | Updates expectations for POSIX special files and adds coverage for POSIX special directories being skipped without marking parts incomplete. |
| tests/ByteSync.Client.IntegrationTests/Services/Inventories/TestInventoryBuilder.cs | Updates POSIX FIFO integration test to assert exclusion from inventory and presence in InventoryProcessData.SkippedEntries. |
| src/ByteSync.Client/Services/Inventories/InventoryBuilder.cs | Refactors file skip logic into TryHandleFileSkip, removes creation of inaccessible descriptions for POSIX special files, and adds warning log for POSIX special directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary:
Key changes:
Notes/risks: