Fix security vulnerabilities (CVEs) 12-01-26 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all vulnerable dependencies without requiring pnpm overrides: - @modelcontextprotocol/sdk: ^1.13.3 → ^1.25.2 (DNS rebinding, ReDoS) - express: ^4.21.2 → ^5.2.1 (qs DoS, body-parser DoS) - axios: ^1.10.0 → ^1.13.2 (SSRF) - multer: ^2.0.1 → ^2.0.2 (DoS) - supertest: ^7.1.1 → ^7.2.2 (form-data, qs) - langchain ecosystem: 0.3.x → 1.x (ws, shell-quote, json5, openai) - eslint: ^9.30.1 → ^9.39.2 (plugin-kit, js-yaml) - typescript-eslint: ^8.35.1 → ^8.52.0 (brace-expansion) - vitest: ^3.2.4 → ^4.0.16 (vite vulnerabilities) Code changes for compatibility: - Logger.ts: Update MCPLogLevel type for MCP SDK 1.25.2 - routes.ts: Handle Express 5.x route param types - Tests: Update mocking patterns for Vitest 4.x Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nickwinder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Security audit identified 17 CVEs (1 critical, 8 high, 3 moderate, 5 low) across the dependency tree. Rather than using pnpm overrides, all vulnerabilities were resolved by updating direct dependencies to their latest versions.
Summary
@modelcontextprotocol/sdkto ^1.25.2 (fixes DNS rebinding and ReDoS vulnerabilities)expressfrom v4 to v5.2.1 (resolves qs and body-parser DoS issues)axiosto ^1.13.2 (fixes SSRF vulnerability)multerto ^2.0.2 (fixes DoS via malformed request)supertestto ^7.2.2 (brings in fixed form-data and qs)eslintto ^9.39.2 andtypescript-eslintto ^8.52.0 (fixes plugin-kit, js-yaml, brace-expansion)vitestto ^4.0.16 (resolves vite vulnerabilities)Code Changes for Compatibility
src/utils/Logger.ts: Updated MCPLogLevel type definition for MCP SDK 1.25.2 API changessrc/dashboard/routes.ts: Handle Express 5.x route param type (string | string[])Verification
pnpm auditreports 0 vulnerabilities