Add SDL3_mixer.pas#24
Merged
Free-Pascal-meets-SDL-Website merged 1 commit intoPascalGameDevelopment:mainfrom Jul 24, 2025
Merged
Add SDL3_mixer.pas#24Free-Pascal-meets-SDL-Website merged 1 commit intoPascalGameDevelopment:mainfrom
Free-Pascal-meets-SDL-Website merged 1 commit intoPascalGameDevelopment:mainfrom
Conversation
This commit adds a translation of SDL3_mixer. This version corresponds to upstream commit 4970bacc5954237037b00f8d2797e23b07782b2f.
Free-Pascal-meets-SDL-Website
requested changes
May 30, 2025
Contributor
Free-Pascal-meets-SDL-Website
left a comment
Free-Pascal-meets-SDL-Website
left a comment
There was a problem hiding this comment.
In general all the bools should be updated to Boolean or the new bool type name (if decided) before merge.
Great contribution, thanks :)!
Contributor
|
As I consider these units (SDL3_gfx and SDL3_mixer) as rather important, I'd prefer to have them merged earlier than later. Do you mind, if we merge them soon/now and add my change requests as issues for later treatment? This would also mean, I could easily fix them myself without pushing commits to your branch. Best regards |
Contributor
|
Excellent, this is finished :)! Thanks! |
Free-Pascal-meets-SDL-Website
merged commit 5d74f91
into
PascalGameDevelopment:main
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a translation of SDL3_mixer. This version corresponds to upstream commit 4970bacc5954237037b00f8d2797e23b07782b2f.