Add floating-point arithmetic functions to SDL_stdinc#37
Conversation
Free-Pascal-meets-SDL-Website
left a comment
Free-Pascal-meets-SDL-Website
left a comment
There was a problem hiding this comment.
Hi there, great etxension. Please have a look at my two comments.
| * \sa SDL_lognf | ||
| * \sa SDL_log10 | ||
| * \sa SDL_exp | ||
| *} |
There was a problem hiding this comment.
Maybe extend this comment by the explanation for the different function name (SDL_logn) as given for this pull request.
"SDL3-for-Pascal: We changed the function name ..."
There was a problem hiding this comment.
The explanation is already there.
There was a problem hiding this comment.
Oh sorry! My bad! Missed your notes.
Please extend the note specifically by "SDL3-for-Pascal NOTE: ..." (or similar). Otherwise our notes are hardly to distinguish from original notes. Then this would be ready to merge and you could merge. I could add this, too if you like. Let me know how to proceed.
Best regards
There was a problem hiding this comment.
Changed. Feel free to edit further, if needed.
| * | ||
| * \sa SDL_logn | ||
| * \sa SDL_expf | ||
| *} |
There was a problem hiding this comment.
See comment above, same could be applied here.
suve
force-pushed
the
add-more-stdinc-symbols
branch
from
8973c8d to
876518c
Compare
|
Excellent! |
Free-Pascal-meets-SDL-Website
merged commit 824fcb3
into
PascalGameDevelopment:main
2 participants
This PR adds missing floating-point arithmetic functions to
SDL_stdinc.As was the case in SDL2, since function names are case-insensitive in Pascal, there is a duplicate identifier conflict between
SDL_log(calculate natural logarithm) andSDL_Log(log a message). As before, I've opted to renameSDL_logtoSDL_logn- making it resembleSDL_log10, the other logarithm function. An alternative approach would be to mark bothSDL_LogandSDL_logasoverload.