ensure 3d points' 4th coordinate is set to 1

[themightyoarfish]

to make vector4f maps to behave as expected for custom point types without additional constructors.

Got bitten by this since i made a custom point type without custom constructor and a library was expecting the points to be homogeneous and computed hard to debug garbage.

[themightyoarfish]

How can i re-run the checks? Cant see why CI cannot build it.

[mvieth]

Since the CI logs keep getting deleted after 2 weeks or so:
Windows64.log
Ubuntu22.log
macOS14.log

Honestly not sure how to solve this. Maybe adding a note to the documentation instead is sufficient?

[themightyoarfish]

It seems to build with the latest change. I can't explain the previous error either, but initializing the data array with a literal seems to work.

[themightyoarfish]

Nevermind, the change fixes build on gcc/clang, but msvc is still unhappy.

[themightyoarfish]

C:\__w\1\s\common\include\pcl\impl\point_types.hpp(539,35): error C1001: Internal compiler error. [C:\build\common\pcl_common.vcxproj]
C:\__w\1\s\common\include\pcl\impl\point_types.hpp(539,35): error C1001: (compiler file 'D:\a\_work\1\s\src\vctools\Compiler\CxxFE\sl\p1\c\p1_init.c', line 13000) [C:\build\common\pcl_common.vcxproj]
C:\__w\1\s\common\include\pcl\impl\point_types.hpp(539,35): error C1001:  To work around this problem, try simplifying or changing the program near the locations listed above. [C:\build\common\pcl_common.vcxproj]
C:\__w\1\s\common\include\pcl\impl\point_types.hpp(539,35): error C1001: If possible please provide a repro here: https://developercommunity.visualstudio.com/  [C:\build\common\pcl_common.vcxproj]
C:\__w\1\s\common\include\pcl\impl\point_types.hpp(539,35): error C1001: Please choose the Technical Support command on the Visual C++  [C:\build\common\pcl_common.vcxproj]
C:\__w\1\s\common\include\pcl\impl\point_types.hpp(539,35): error C1001:  Help menu, or open the Technical Support help file for more information [C:\build\common\pcl_common.vcxproj]
  (compiling source file '../../__w/1/s/common/src/point_types.cpp')

wat

[themightyoarfish]

I am also unsuccessfull reproducing this with godbolt: https://godbolt.org/z/hKnb1KWzr

it compiles and runs normally in x64 msvc, but does not even run with x86 msvc, but also no compile error. Maybe we need the same compile flags which the PCL CI uses, but i think I won't be able to fix this, since i don't know anything about windows development.

we could add a hint in the documentation, but i doubt this will save anyone from wasting many hours on this before they think to look there.