Fixed p1_capture socket recv call in Windows. #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recvmsg() and kernel timestamping is not supported in Windows.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a platform compatibility issue in the p1_capture application where recvmsg() and kernel timestamping were being used on non-Linux platforms (specifically Windows), which don't support these features.
Key changes:
- Added platform-specific logic to use
recvmsg()with ancillary data only on Linux - Falls back to standard
recv()on non-Linux platforms (Windows, macOS, etc.)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wbrannon
approved these changes
Nov 13, 2025
Contributor
wbrannon
left a comment
wbrannon
left a comment
There was a problem hiding this comment.
Looks good, please check the copilot comment - it may be right in its analysis.
Collaborator
Author
|
@wbrannon it was right, more or less. It was saying that the enable timestamp function also needed a check for Windows. I fixed that and added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recvmsg() and kernel timestamping is not supported in Windows.