Skip to content

Update depends_on macos #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xtqqczze wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update depends_on macos #1297

xtqqczze wants to merge 1 commit into from
+12 −8

Conversation

@xtqqczze
Copy link

@xtqqczze xtqqczze commented Sep 24, 2025 •
edited
Loading

Update macOS depends_on to reflect .NET’s supported OS at each release’s ship date.

@xtqqczze xtqqczze changed the title Update depends_on macos Update depends_on macos Sep 24, 2025
@xtqqczze xtqqczze marked this pull request as ready for review September 24, 2025 18:15
xtqqczze
xtqqczze commented Sep 24, 2025
View reviewed changes
Formula/powershell-lts.rb Outdated
# .NET Core 3.1 requires High Sierra - https://docs.microsoft.com/en-us/dotnet/core/install/dependencies?pivots=os-macos&tabs=netcore31
depends_on macos: :high_sierra
# .NET 8 requires macOS 13 (Ventura) - https://github.com/dotnet/core/blob/main/release-notes/8.0/supported-os.md#apple
depends_on macos: :ventura
Copy link
Author

@xtqqczze xtqqczze Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depends_on macos: :ventura
depends_on macos: :catalina

Another option: .NET 8 was originally released with support for macOS 10.15 (Catalina)

@ZhongRuoyu
Copy link

ZhongRuoyu commented Nov 5, 2025

Please note that depends_on macos: :high_sierra (and any macOS version below Catalina) will be deprecated in the next Homebrew release, so it will no longer be possible to install these formulae without bumping the macOS requirement (which I see this PR is doing):

$ brew install powershell/tap/powershell
Error: powershell/tap/powershell: Calling `depends_on macos: :high_sierra` is deprecated! There is no replacement.
Please report this issue to the powershell/homebrew-tap tap (not Homebrew/* repositories):
  /opt/homebrew/Library/Taps/powershell/homebrew-tap/Formula/powershell.rb:33

@ZhongRuoyu ZhongRuoyu mentioned this pull request Nov 10, 2025
Open
3 tasks
@amaiman amaiman mentioned this pull request Nov 19, 2025
Closed
@kevindashton
Copy link

kevindashton commented Dec 17, 2025 •
edited
Loading

@andyleejordan @TravisEz13 Can we get the final review and get this merged? These constant deprecation warnings on any brew command have me close to uninstalling pwsh.

@kevindashton kevindashton mentioned this pull request Dec 17, 2025
Open
3 tasks
@bitcrazed
Copy link

bitcrazed commented Jan 8, 2026

Hi, @TravisEz13 and/or @andyleejordan Any chance one of you could review & approve this PR ... pretty please? 😜

@dskeller
Copy link

dskeller commented Jan 10, 2026

please approve and integrate. this breaks update functionality in the homebrew implementation of powershell.

@Makishima
Copy link

Makishima commented Jan 17, 2026

Please approve it, @TravisEz13 and @andyleejordan :)

@xtqqczze xtqqczze requested a review from TravisEz13 January 29, 2026 01:36
@xtqqczze
Copy link
Author

xtqqczze commented Jan 29, 2026

I’ve pushed changes to use the minimum supported OS at the time of the first .NET RC to avoid unnecessary warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyleejordan andyleejordan Awaiting requested review from andyleejordan andyleejordan is a code owner

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

2 more reviewers

@calebhearth calebhearth calebhearth approved these changes

@Hashimlokasher Hashimlokasher Hashimlokasher approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@xtqqczze @ZhongRuoyu @kevindashton @bitcrazed @dskeller @Makishima @calebhearth @Hashimlokasher @TravisEz13