Allow reference links with backticks (again) #1582
Draft
+135
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martynp
force-pushed
the
reference_links_with_backtick_support
branch
2 times, most recently
from
2bd2040 to
99dc4f7
Compare
martynp
force-pushed
the
reference_links_with_backtick_support
branch
from
99dc4f7 to
f0487a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@facelessuser
Thoughts appreciated - I did have this working on a previous version, but seem to have dropped the test and broke it in the re-write. Thought it was a bit too simple.
Previously I was expanding the backtick within reference, then comparing against the stashed nodes.
So find reference and expand to [some
content] then storing that as the references list.Then in the inline reference processor, all of the stashed_nodes were expanded and then the reference comparison happens.