Conversation
JohanMabille
force-pushed
the
rm_command
branch
from
24532d3 to
ffc8ede
Compare
ianthomas23
approved these changes
Feb 9, 2026
SandrineP
reviewed
Feb 9, 2026
src/subcommand/rm_subcommand.cpp
Outdated
| if (!repo.does_track(path)) | ||
| { | ||
| std::string msg = "fatal: pathsspec '" + path + "'is not tracked"; | ||
| throw git_exception(msg, 128); |
Collaborator
There was a problem hiding this comment.
You can use the new git2cpp_error_code here.
| # Check git status - should show nothing staged | ||
| status_cmd = [git2cpp_path, "status", "--long"] | ||
| p_status = subprocess.run(status_cmd, capture_output=True, cwd=xtl_path, text=True) | ||
| assert p_status.returncode == 0 |
Collaborator
There was a problem hiding this comment.
You don't check that nothing was staged.
JohanMabille
force-pushed
the
rm_command
branch
from
80283e1 to
91d80a5
Compare
SandrineP
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.