fix(business): Correct validation for UNIQUE promo updates#24
Merged
RandomProgramm3r merged 1 commit intomainfrom Apr 15, 2025
Merged
fix(business): Correct validation for UNIQUE promo updates#24RandomProgramm3r merged 1 commit intomainfrom
RandomProgramm3r merged 1 commit intomainfrom
Conversation
PATCH requests to update fields (like description or image_url) on promos with mode='UNIQUE' failed. The validator incorrectly required the `promo_unique` field to be present in the input data. This commit removes the erroneous check for `promo_unique` presence from the `PromoDetailSerializer.validate` method when handling updates for UNIQUE promos, allowing partial updates to proceed correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PATCH requests to update fields (like description or image_url) on promos with mode='UNIQUE' failed. The validator incorrectly required the
promo_uniquefield to be present in the input data.This commit removes the erroneous check for
promo_uniquepresence from thePromoDetailSerializer.validatemethod when handling updates for UNIQUE promos, allowing partial updates to proceed correctly.