test: Add comprehensive tests for PromoComment#50
Merged
RandomProgramm3r merged 1 commit intomainfrom Jun 21, 2025
Merged
Conversation
This commit introduces a new test suite, `PromoCommentsTestCase`, to provide robust test coverage for the promo comments API endpoints. Key functionality covered: - **CRUD Operations**: Full lifecycle testing for creating (POST), retrieving (GET list/detail), updating (PUT), and deleting (DELETE) comments. - **Permissions**: Verifies that users can only modify or delete their own comments (403 Forbidden). - **Error Handling**: Validates correct 404 Not Found responses for invalid requests, such as mismatched promo and comment IDs. - **Data Integrity**: Ensures the `comment_count` on the parent Promo object is correctly updated after comments are created or deleted. - **Listing & Pagination**: Confirms that comments are listed in reverse chronological order and that pagination headers (`X-Total-Count`) are accurate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new test suite,
PromoCommentsTestCase, to provide robust test coverage for the promo comments API endpoints.Key functionality covered:
comment_counton the parent Promo object is correctly updated after comments are created or deleted.X-Total-Count) are accurate.