test: Add comprehensive tests for user promo operations#54
Merged
RandomProgramm3r merged 1 commit intomainfrom Jul 4, 2025
Merged
test: Add comprehensive tests for user promo operations#54RandomProgramm3r merged 1 commit intomainfrom
RandomProgramm3r merged 1 commit intomainfrom
Conversation
This commit introduces a suite of tests for the user-facing promo code functionality, ensuring robustness and correctness.
The new tests cover the following areas:
- Promo Code Activation:
- Verification of activation logic, including success and failure scenarios for common and unique promos.
- Edge cases such as inactive promos, targeting mismatches, and exhausted activation limits (max_count).
- Checks to prevent users who are blocked by the anti-fraud service from activating promos.
- Promo Activation History:
- Tests for the user's promo activation history endpoint.
- Validation of the returned data and its order.
- Pagination functionality (limit and offset).
- Anti-Fraud Service Integration:
- Unit tests for the AntiFraudService to verify its caching behavior and resilience to external service failures.
- Integration tests to confirm that the promo activation process correctly respects the anti-fraud service's verdicts, including delayed updates from the cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a suite of tests for the user-facing promo code functionality, ensuring robustness and correctness.
The new tests cover the following areas:
Promo Code Activation:
Promo Activation History:
Anti-Fraud Service Integration: