Open
Conversation
Razdeep
requested changes
Oct 11, 2020
Owner
Razdeep
left a comment
Razdeep
left a comment
There was a problem hiding this comment.
I have requested some minor changes in your PR.
docs/README-windows.md
Outdated
|
|
||
| ## Prerequisite | ||
|
|
||
| The steps are tested under this envionment. Please prepare these installed. |
docs/README-windows.md
Outdated
|
|
||
| ## Notes on install Cmake | ||
|
|
||
| In order to run Cmake in `CMD`, please make sure `PATH envionment variable` contains the folder of Cmake. eg: `C:\Program Files\CMake\bin` |
docs/README-windows.md
Outdated
| ## Notes on install OpenCV | ||
|
|
||
| The folder location of OpenCV is important. This program depends on this library. | ||
| The downloaded OpenCV file is usually an archive (self-extracting archive). Please extract to a certain folder. eg: `D:\opencv` (i.e. the `opencv extrated folder`) |
docs/README-windows.md
Outdated
| opencv_world3411d.pdb | ||
| ``` | ||
|
|
||
| **Alternatively**, one may add the path of OpenCV binary (eg: `D:\opencv\build\x64\vc15\bin`) to `PATH envionment variable`. You may refer to this [web page](https://www.deciphertechnic.com/install-opencv-with-visual-studio/). |
docs/README-windows.md
Outdated
|
|
||
| ## Notes on install libwebp | ||
|
|
||
| It locates within `Repo folder`, eg: `D:\splitwebp\3rdparty\libwebp\lib\windows-x64` |
Owner
There was a problem hiding this comment.
Instead of calling it Repo folder, wouldn't it be specific call it something like "splitwebp root directory"
docs/README-windows.md
Outdated
|
|
||
| In Properties, go to C/C++ > Additional Include Directories > click on the value and see a pull down menu > click Edit.. > click New Line. And add these paths: | ||
|
|
||
| (if your `opencv extrated folder` is `D:\opencv`) |
docs/README-windows.md
Outdated
|
|
||
| 1) > By not providing "FindOpenCV.cmake" in CMAKE_MODULE_PATH | ||
|
|
||
| Solution: set the `envionment variable` named `OPENCV_DIR`. Open `CMD`, and run this command (This may require Administrator right. ): |
docs/README-windows.md
Outdated
|
|
||
| - `System32 folder` An important folder for Windows to run. It contains system files and libraries binary. It usually locates at `C:\Windows\System32` | ||
|
|
||
| - `opencv extrated folder` eg: `D:/opencv` |
docs/README-windows.md
Outdated
| ## Glossory | ||
| - `CMD` Command Prompt in Windows, accept user's command. Run it by: Start Menu => search "cmd" => click "Command Prompt" OR Start Menu > "Run" > type "cmd" > press Enter | ||
|
|
||
| - `Repo folder` The folder of this repository cloned into your local machine. eg: `D:\splitwebp` |
Owner
There was a problem hiding this comment.
If you changed the "repo folder" to "splitwebp", then don't forget to delete this line :P
Author
|
I pushed new commit to fix the typo mistakes, remove the pre-built webp library binary, add the instructions for using |
oktak
force-pushed
the
docs/windows_install
branch
from
a39c5ad to
e6c4eda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I added some steps to build in Windows 10 as a README file for issue #1
But it seems need further code modification for successfully making this to split animated webp files.