Conversation
alimtunc
force-pushed
the
low-level
branch
6 times, most recently
from
a42fc55 to
7245340
Compare
alimtunc
force-pushed
the
low-level
branch
12 times, most recently
from
6dfbb0d to
32e3d18
Compare
alimtunc
changed the title
alimtunc
force-pushed
the
low-level
branch
3 times, most recently
from
ca7b203 to
da7cdba
Compare
| if (propertyValue) { | ||
| await meetJs.createLocalTracks({ devices: ['desktop'] }).then((tracks) => { | ||
| const screenNode = document.querySelector('#video-screen-me') | ||
| const screenTrack = tracks[0] | ||
|
|
||
| screenTrack.attach(screenNode) | ||
| this.room.addTrack(screenTrack) | ||
|
|
||
| localTracks.push(screenTrack) | ||
| this.localTracks.set(localTracks) | ||
| }) | ||
| } else { | ||
| let filteredLocalTracks = localTracks.filter((track) => { | ||
| if (track.getType() === 'video' && track.getVideoType() === 'desktop') { | ||
| track.dispose() | ||
| return false | ||
| } else { | ||
| return true | ||
| } | ||
| }) | ||
|
|
||
| this.localTracks.set(filteredLocalTracks) |
There was a problem hiding this comment.
maybe this logic should be in updateTrack as well?
There was a problem hiding this comment.
Hum, why? Update track does a different thing. This logic is for the shareScreen props, wich doesn't need to use updateTrack, since it's just for audio/video to mute or unmute it without removing the track.
There was a problem hiding this comment.
I just don't understand why shareScreen is handled differently and in a different place than shareAudio or shareVideo
There was a problem hiding this comment.
Because the share screen track is independant track, it will be created/deleted when user want. The audio and video track are created at the initialization of the connection. When ever user toggle share audio/video, it will be muted. But when it's share screen CTA, it will be created a this moment.
There was a problem hiding this comment.
Why the different behaviors? Why don't we create the video track only when the user wants to share its video?
There was a problem hiding this comment.
Actually, I just followed the doc and never thinked about that, but yes, I think we can do that.
alimtunc
force-pushed
the
low-level
branch
2 times, most recently
from
c59b043 to
3c2357d
Compare
3 participants
Re-open of #45 :
Tasks :
Thinking :
Useful links :