Fix issue of filtering the properties while sharing profile#149
Open
devanshkansagra wants to merge 1 commit intoRocketChat:mainfrom
Open
Fix issue of filtering the properties while sharing profile#149devanshkansagra wants to merge 1 commit intoRocketChat:mainfrom
devanshkansagra wants to merge 1 commit intoRocketChat:mainfrom
Conversation
Author
|
Hey @samad-yar-khan, can you review this pr. In this pr I have achieved the expected behaviour of issue #148. |
Author
|
Hey @samad-yar-khan, it's been a while since you haven't reviewed this PR, as well as PR #150. Could you take a look and provide your feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
Closes #148
Acceptance Criteria fulfillment
I have set the value to true in
this.persistence.updateByAssociation(new RocketChatAssociationRecord(RocketChatAssociationModel.MISC, "ProfileShareParam"), storeData, true);in case ofSHARE_PROFILE_PARAMSsuch that if fixes the filtering of properties while sharing the profileProposed changes (including videos or screenshots)
Screencast.from.26-12-24.12.00.27.AM.IST.webm