[FEAT] /gh gist for quicker sharing of Gist in chat.#35
Open
henit-chobisa wants to merge 33 commits intoRocketChat:mainfrom
Open
[FEAT] /gh gist for quicker sharing of Gist in chat.#35henit-chobisa wants to merge 33 commits intoRocketChat:mainfrom
/gh gist for quicker sharing of Gist in chat.#35henit-chobisa wants to merge 33 commits intoRocketChat:mainfrom
Conversation
henit-chobisa
changed the title
/gh gist for quicker sharing of Gist in chat.
Contributor
Author
|
@samad-yar-khan |
henit-chobisa
changed the title
/gh gist for quicker sharing of Gist in chat./gh gist for quicker sharing of Gist in chat.
Contributor
|
@henit-chobisa Thankyou for putting in this work 🙌. I will review the code changes, test it once and let you know. |
Contributor
Author
|
@samad-yar-khan |
Contributor
|
@henit-chobisa Can you please take a look at this and clean up this PR. Please mention me whenever its ready for a review. |
Contributor
Author
|
Sure, @samad-yar-khan, I try to resolve the PR |
Contributor
|
Hey @henit-chobisa is this PR still being worked on ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
Closes #34
Acceptance Criteria fulfillment
Gist Modalfor displaying the existing gist created by the User.DualParamCommandand a newTrippleParamCommandfor executinggistfeature.IGistandIGistFileInterfaces for structuring the data according to the SDK.Gistin GithubSDK.Proposed changes (including videos or screenshots)
gistdual and triple param command.UserGistModal.