Open
Conversation
Contributor
samad-yar-khan
left a comment
There was a problem hiding this comment.
@henit-chobisa Why does this completely remove userIssuesModal and if it does, did we check for backward compatibility incase the modal was being used elsewhere ?
Contributor
Author
@samad-yar-khan, I have checked all the places where the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #94
Issue(s)
We have a button in UserProfileView, which tends to open user's issues, with it's states of mentioned / created and open / close, but the supporting SurfaceView that lists the issues is a ModalView which is not the best solution to display list like data, hence I request to switch to Contextual Bar View, which doesn't block user's activity while working on any chat and keeps the issues handy in contextual bar.
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)