[bug] :Share profile modal closes on submit#96
Open
chinma-yyy wants to merge 1 commit intoRocketChat:mainfrom
Open
[bug] :Share profile modal closes on submit#96chinma-yyy wants to merge 1 commit intoRocketChat:mainfrom
chinma-yyy wants to merge 1 commit intoRocketChat:mainfrom
Conversation
Contributor
Author
|
Hey @samad-yar-khan I have raised the PR again . Its ready for review. |
Contributor
Author
|
Hey @samad-yar-khan can you review this. This is a serious bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
closes #89
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)
Screencast.from.01-04-23.12.46.23.AM.IST.webm
Further comments
So here the share to chat button was an action button not a submit button so I moved the handler from action handler to view submit handler and also provided the submitted button to the view with the enum