feat: detect links in user bio #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add parseUrls utility function to detect URLs in bio text - Convert detected URLs to clickable links with proper styling - Match email link styling for consistency - Support both http/https URLs and URLs without protocol
|
|
| import { css } from '@emotion/react'; | ||
| import { Box } from '@embeddedchat/ui-elements'; | ||
|
|
||
| const URL_REGEX = /(https?:\/\/[^\s<>"']+)/gi; |
Collaborator
There was a problem hiding this comment.
In EmbeddedChat, we might be using a parser library to handle link scenarios. It would be better to explore that option instead of relying on a custom parser, which could fail in various situations. Thanks.
Contributor
Author
There was a problem hiding this comment.
ok, Will look into this
Contributor
Author
There was a problem hiding this comment.
In EmbeddedChat, we might be using a parser library to handle link scenarios. It would be better to explore that option instead of relying on a custom parser, which could fail in various situations. Thanks.
Screencast.From.2026-01-15.15-27-34.mp4
Got it, updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make URLs in user bio clickable
Acceptance Criteria fulfillment
http://orhttps://in bio are automatically detectedtarget="_blank"andrel="noopener noreferrer")Implementation Details
styleprop matching email link pattern for consistencyparseUrls.jsfor URL detectionUserInformation.jsto use parseUrls for bio fieldFixes #1055
Screenshots
Light theme
Dark theme
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace
<pr_number>with the actual PR number.