feat: treat messages without tools as follow-up questions (ROO-400) #10495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add hideHeader flag to FollowUpData interface to optionally hide 'Roo has a question' header - Modify no-tool handling in Task.ts to present as follow-up instead of error - Update ChatRow.tsx to conditionally hide header when hideHeader is true - Relax strict tool-per-message requirement in system prompt - Remove error treatment (MODEL_NO_TOOLS_USED) for no-tool responses - Remove consecutiveMistakeCount increment for no-tool scenarios - Add comprehensive test coverage
dosubot
bot
added
size:XL
Contributor
Review complete. No issues found. All changes were reviewed and the implementation is correct:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
mrubens
reviewed
Jan 6, 2026
| TOOL USE | ||
| You have access to a set of tools that are executed upon the user's approval. You must use exactly one tool per message, and every assistant message must include a tool call. You use tools step-by-step to accomplish a given task, with each tool use informed by the result of the previous tool use. |
Collaborator
There was a problem hiding this comment.
Do you know how much this change impacts things?
- Add nonInteractive: true to CLI integration test - Add alwaysAllowFollowupQuestions: true to vscode-e2e tests - Ensures tests auto-continue when model doesn't use tools - Fixes timeout issues introduced by relaxed tool requirement in system prompt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modifies the extension so that when the AI model produces a message without any tool calls, it's treated as a follow-up question instead of an error.
Linear: https://linear.app/roocode/issue/ROO-400
Behavior
autoApprovalEnabledalwaysAllowFollowupQuestionsChanges
packages/types/src/followup.ts- AddedhideHeader?: booleanflag toFollowUpDatainterfacesrc/core/task/Task.ts- Modified no-tool handling to present as follow-up instead of errorwebview-ui/src/components/chat/ChatRow.tsx- Added logic to hide "Roo has a question" header whenhideHeaderis truesrc/core/prompts/sections/tool-use.ts- Relaxed strict tool-per-message requirementKey Improvements
MODEL_NO_TOOLS_USED) for no-tool responsesconsecutiveMistakeCountincrement for this scenariohideHeaderflag to avoid showing "Roo has a question" header when not appropriateTesting
no-tool-followup.spec.tsImportant
Treats AI messages without tool calls as follow-up questions, adding a
hideHeaderflag for UI control and updating logic for auto-approval settings.Task.ts.hideHeaderflag inFollowUpDatato control UI display inChatRow.tsx.Task.tsto handle different configurations ofautoApprovalEnabledandalwaysAllowFollowupQuestions.no-tool-followup.spec.tswith 6 unit tests to verify new behavior.MODEL_NO_TOOLS_USEDerror handling.tool-use.tsto relax tool-per-message requirement.This description was created by
for 0da4d35. You can customize this summary. It will automatically update as commits are pushed.