fix: add UI progress indicator for Background Editing file operations #10506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ools When the preventFocusDisruption (Background Editing) experiment is enabled, file writing operations now display a progress indicator (spinner) in the chat UI before file operations begin. This addresses Issue #10504 where users would see no visual feedback while Roo was preparing and writing files in the background, causing confusion about whether the app had frozen. Files updated: - WriteToFileTool.ts - ApplyDiffTool.ts - MultiApplyDiffTool.ts - SearchAndReplaceTool.ts - SearchReplaceTool.ts - EditFileTool.ts
Contributor
Author
Review completed. No issues found. The changes correctly add a progress indicator to the Background Editing feature by sending a partial message before file operations begin. The implementation is consistent across all 6 tool files and follows existing patterns in the codebase. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
lemiesz
suggested changes
Jan 7, 2026
lemiesz
left a comment
lemiesz
left a comment
There was a problem hiding this comment.
I have an overall comment about swallowing errors in an empty catch block.
Is that considered okay in this repo?
| if (isPreventFocusDisruptionEnabled) { | ||
| // Show progress indicator in UI while preparing the file | ||
| const partialMessage = JSON.stringify(sharedMessageProps) | ||
| await task.ask("tool", partialMessage, true).catch(() => {}) |
There was a problem hiding this comment.
why is it okay to just swallow the error here?
| // Show progress indicator in UI while preparing the file when background editing is enabled | ||
| if (isPreventFocusDisruptionEnabled) { | ||
| const partialMessage = JSON.stringify(sharedMessageProps) | ||
| await task.ask("tool", partialMessage, true).catch(() => {}) |
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #10504
Description
This PR attempts to address Issue #10504 by adding a progress indicator (spinner) in the chat UI when the preventFocusDisruption (Background Editing) experimental feature is enabled.
Root Cause: When Background Editing is enabled, the file writing tools skip sending a partial message to the UI that would normally trigger a progress indicator. In the normal flow,
task.ask("tool", partialMessage, true)is called before showing the diff editor, which displays a loading spinner in the chat. When background editing is enabled, this step was skipped entirely.Solution: Added a partial message call (
task.ask("tool", partialMessage, true)) at the start of theisPreventFocusDisruptionEnabledcode path in all file edit tools. This displays the existingProgressIndicatorcomponent in the chat while the background file operation is in progress.Files modified:
src/core/tools/WriteToFileTool.tssrc/core/tools/ApplyDiffTool.tssrc/core/tools/MultiApplyDiffTool.tssrc/core/tools/SearchAndReplaceTool.tssrc/core/tools/SearchReplaceTool.tssrc/core/tools/EditFileTool.tsTest Procedure
Automated Tests: All 326 existing tool tests pass. TypeScript compilation and ESLint checks pass.
Pre-Submission Checklist
Screenshots / Videos
N/A - The change uses the existing
ProgressIndicatorcomponent that is already displayed for partial messages.Documentation Updates
Additional Notes
Feedback and guidance are welcome. This is a minimal fix that adds the missing partial message calls to provide visual feedback during background file operations.
Get in Touch
Discord: @roomote