Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Jan 7, 2026

Summary

Ensure the Z.ai provider uses the model's when the user has not set , matching the precedence used elsewhere.

Changes

  • Update temperature resolution in to prefer over provider defaults.
  • Add regression tests covering temperature precedence in .

Important

Fixes temperature precedence in ZAiHandler to use model's defaultTemperature when modelTemperature is not set, with tests added.

  • Behavior:
    • Update temperature resolution in zai.ts to prefer info.defaultTemperature over provider defaults when modelTemperature is not set.
    • Add regression tests in zai.temperature.spec.ts to verify temperature precedence.
  • Tests:
    • Test that ZAiHandler uses defaultTemperature when modelTemperature is not set.
    • Test that ZAiHandler uses modelTemperature when it is set.

This description was created by Ellipsis for 4e324f0. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Jan 7, 2026
@roomote
Copy link
Contributor

roomote bot commented Jan 7, 2026

Oroocle Clock   See task on Roo Cloud

Reviewed. No issues found; the temperature precedence change matches the shared OpenAI-compatible behavior.

  • No issues flagged

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants