chore: remove XML tool calling support #10841
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
Contributor
Re-reviewed latest changes. All previously flagged items look resolved, and no new issues found in this review.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Contributor
|
Generated with ❤️ by ellipsis.dev |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
…allParser - Add list_files case to parseToolCall() switch with path/recursive args - Add new_task case to parseToolCall() switch with mode/message/todos args - Add list_files to NativeToolArgs type in tools.ts - Both tools were in toolNames but lacked case handlers, causing the fail-fast check on line 852 to throw 'Invalid arguments for tool'
- Remove redundant pushToolResult after handleError in BaseTool.ts (handleError already emits tool_result via formatResponse.toolError) - Fix containsXmlToolMarkup to exclude content inside markdown code fences, preventing false positives when users paste docs/examples - Make 'wait for confirmation' guideline conditional on !isMultipleNativeToolCallsEnabled to avoid contradicting multiple-tools-per-message guidance - Update tests to reflect intentional behavior changes
mrubens
reviewed
Jan 20, 2026
mrubens
reviewed
Jan 20, 2026
mrubens
reviewed
Jan 20, 2026
mrubens
reviewed
Jan 20, 2026
mrubens
reviewed
Jan 20, 2026
- Remove useNativeTools variable and inline metadata?.tools?.length checks - Updated: lm-studio, lite-llm, unbound, cerebras, xai, native-ollama, qwen-code, deepinfra, vscode-lm, requesty, bedrock - Remove dead extractToolSpecsFromMessages() method from bedrock - Tools are always provided in Roo Code, no need for historical tool detection
…I providers After PR #10841, tools are ALWAYS present (minimum 6 from ALWAYS_AVAILABLE_TOOLS) and tool_choice is always set to 'auto' when tools are present. This eliminates the need for defensive conditional checks. Changes: - Simplified 27 API provider files to use direct property assignments - Updated 14 test files to reflect new behavior where tools are always present - Changed patterns from conditional spreads to direct assignments: Before: ...(metadata?.tools?.length ? { tools: ... } : {}) After: tools: convertTools(metadata?.tools ?? []) All 859 provider tests pass.
- Remove unused xmlInfo variables in ReadFileTool.ts (renamed to toolInfo for clarity) - Fix test name in multiApplyDiffTool.spec.ts to reflect native protocol - All tests passing
… true Matt pointed out in PR #10458 review that this behavioral change should be handled separately. This reverts to the original behavior where: - parallel_tool_calls is only sent to API when explicitly set to true - When false or undefined, the parameter is omitted entirely (allows API defaults) Updated 13 provider files and 8 test files to restore this behavior.
mrubens
reviewed
Jan 20, 2026
Always send parallel_tool_calls explicitly (defaulting to false) instead of only sending when truthy. This preserves the original behavior when toolProtocol was "native".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10848
Removes all legacy XML-based tool calling support with zero fallback.
Validation: