revert to env var approach for skipping clippy for build scripts #23
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fee1-dead
force-pushed
the
clippy-skips
branch
from
3562f96 to
4808249
Compare
Member
|
Thanks 🎉 I may just push out another minor release afterwards. (Also, I forgot to turn on notifications for all activity in this repo, just found this by you mentioning another PR in internal chat) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR (#16) had this approach initially. Indeed running
cargo clippywould be fine for the build script to takecfg!(clippy), but the problem here is that thatcfg!magically disappears if I am in a workspace that does not havespirv-tools-sysas a root (rather as a dependency).