Closed
Conversation
8c8ac52 to
7ecda0c
Compare
Member
|
Have you seen #86? It's already merged by Danilo in the kernel and I'll merge it here soon as well. |
7ecda0c to
ab465ec
Compare
Member
|
I'd like to avoid making let bindings in Additionally to #86, I wanted to eventually do #69 which allows extending the body to a closure, so executing arbitrary code before the initializer in the macro |
Signed-off-by: Matthew Maurer <mmaurer@google.com>
ab465ec to
a06a5e9
Compare
Author
Oh, if it's already merged I'll use that. I saw the PR was months old and thought it wasn't landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inspiration for this change is mostly modeled by the
splittest below. The real world case looks like this:Previously, I handled this by just putting the
_: {}block beforetry_pin_init, and returning aResult<KBox<Self>, Error>, but theprobeinterface has changed.