Add method to query latency from Stream#964
Open
marcpabst wants to merge 4 commits intoRustAudio:masterfrom
Open
Add method to query latency from Stream#964marcpabst wants to merge 4 commits intoRustAudio:masterfrom
Stream#964marcpabst wants to merge 4 commits intoRustAudio:masterfrom
Conversation
Author
|
I think this can be reviewed now - so far it only implements |
Author
|
Could I get some feedback on this? I'm considering pouring some work into Edit: This was not meant to be offsensive at all, but it would be good to see if there's interest in this! |
est31
approved these changes
May 16, 2025
Member
|
@marcpabst I got added as maintainer and am doing some backlog grooming. Yes there is interest in this. I'd like to ensure that a sensical number of hosts would be supported coming out of the gates. So beyond CoreAudio also Alsa and WASAPI? |
roderickvd
added a commit
that referenced
this pull request
Dec 23, 2025
Add buffer_size() method to Stream trait that returns the number of frames passed to each data callback invocation (actual size or upper limit depending on platform). AAudio improvements: - BufferSize::Default now explicitly configures using optimal burst size from AudioManager, following Android low-latency audio best practices - buffer_size() query falls back to burst size if frames_per_data_callback was not explicitly set - Refactored buffer configuration to eliminate code duplication Addresses #1042 Relates to #964, #942
roderickvd
added a commit
that referenced
this pull request
Jan 2, 2026
Add buffer_size() method to Stream trait that returns the number of frames passed to each data callback invocation (actual size or upper limit depending on platform). AAudio improvements: - BufferSize::Default now explicitly configures using optimal burst size from AudioManager, following Android low-latency audio best practices - buffer_size() query falls back to burst size if frames_per_data_callback was not explicitly set - Refactored buffer configuration to eliminate code duplication Addresses #1042 Relates to #964, #942
roderickvd
added a commit
that referenced
this pull request
Jan 3, 2026
Add buffer_size() method to Stream trait that returns the number of frames passed to each data callback invocation (actual size or upper limit depending on platform). AAudio improvements: - BufferSize::Default now explicitly configures using optimal burst size from AudioManager, following Android low-latency audio best practices - buffer_size() query falls back to burst size if frames_per_data_callback was not explicitly set - Refactored buffer configuration to eliminate code duplication Addresses #1042 Relates to #964, #942
roderickvd
added a commit
that referenced
this pull request
Jan 3, 2026
Add buffer_size() method to Stream trait that returns the number of frames passed to each data callback invocation (actual size or upper limit depending on platform). AAudio improvements: - BufferSize::Default now explicitly configures using optimal burst size from AudioManager, following Android low-latency audio best practices - buffer_size() query falls back to burst size if frames_per_data_callback was not explicitly set - Refactored buffer configuration to eliminate code duplication Addresses #1042 Relates to #964, #942
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is initial work to enable getting the current latency in samples from a Stream. The
latency() -> Option<u32>method returnsNoneby default, so this will already compile with all backends. So far, an implementation for coreaudio on MacOS is provided.Addreses #773.