Fixed Player::skip_one not updating player's length immediately.#842
Open
nieboczek wants to merge 3 commits intoRustAudio:masterfrom
Open
Fixed Player::skip_one not updating player's length immediately.#842nieboczek wants to merge 3 commits intoRustAudio:masterfrom
nieboczek wants to merge 3 commits intoRustAudio:masterfrom
Conversation
Also added Done::should_decrease to achieve that.
Author
|
Something very bad seems to be happening with the Player, adding a simple
|
Author
|
I've hopefully fixed that. Also saw a queue issue where it wouldn't play the first audio appended in my own app with the version from the PR, but that is working correctly after my latest commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #497.
Needed to add
Done::should_decrementto achieve this fix.Instead of updating
sound_countin the periodic access source, I made it update directly in theskip_onefunction (clearaffected too).When
controls.to_clear > 0in periodic access, it will useDone::should_decrementto temporarily disable decrementingsound_count.