Separate Nova 7P into its own device class without sidetone/chatmix #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #450 - The Arctis Nova 7P has different hardware behavior compared to the Nova 7/7X variants: - The dial controls sidetone instead of chatmix - Sidetone setting has no effect - Chatmix always returns a fixed value (64) This commit creates a separate SteelSeriesArctisNova7P class that inherits from SteelSeriesArctisNova7 but disables CAP_SIDETONE and CAP_CHATMIX_STATUS. Changes: - Add new steelseries_arctis_nova_7p.hpp with Nova 7P-specific class - Remove 0x220a (Nova 7P) from Nova 7 device class - Register Nova 7P as separate device in device_registry.cpp - Update README.md device table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450 - The Arctis Nova 7P has different hardware behavior compared to the Nova 7/7X variants:
This commit creates a separate SteelSeriesArctisNova7P class that inherits from SteelSeriesArctisNova7 but disables CAP_SIDETONE and CAP_CHATMIX_STATUS.
Changes: