-
Notifications
You must be signed in to change notification settings - Fork 106
Create graalvm25.json #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a new Scoop manifest file Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with graalvm25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/graalvm25.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull Requests
bucket/graalvm25.json
[error] 1-1: Checkver: Version check failed for graalvm25.json. Could not match latest GraalVM version pattern on downloads page; autoupdate skipped.
🔇 Additional comments (3)
bucket/graalvm25.json (3)
8-11: Verify pre_install script handles all extraction scenarios correctly.The pre_install PowerShell script normalizes the extracted directory structure by detecting a single nested folder and moving its contents to the parent. Verify this handles the GraalVM 25.0.1 Windows distribution correctly.
Please confirm:
- The GraalVM Community Edition Windows x64 release actually extracts to a nested directory (e.g.,
graalvm-community-jdk-25.0.1/)- The script logic is compatible with PowerShell versions available on target Windows systems
If the extraction behavior differs or the script logic needs refinement, adjust accordingly.
1-27: Verify manifest structure aligns with other Java manifests in the repository.This is a new manifest for GraalVM. Ensure the structure, naming conventions, and configuration patterns align with existing Java/JDK manifests in the
ScoopInstaller/Javabucket to maintain consistency.Review similar manifests (e.g.,
graalvm*.json,openjdk*.json, or other JVM distributions) to confirm:
- License field format and value are consistent
- Environment variable setup matches precedent
- checkver and autoupdate patterns follow established conventions
- Pre_install logic is appropriate for this distribution type
6-7: I'll help you verify the download URL and hash integrity for this GraalVM 25 entry. Let me start by testing the URL accessibility and examining the file context.
<function_calls>
#!/bin/bashTest main download URL accessibility
echo "=== Testing main download URL ==="
curl -sI 'https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-25.0.1/graalvm-community-jdk-25.0.1_windows-x64_bin.zip' | head -1Test SHA-256 file availability
echo -e "\n=== Testing SHA-256 file URL ==="
curl -sI 'https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-25.0.1/graalvm-community-jdk-25.0.1_windows-x64_bin.zip.sha256' | head -1
</function_calls>Now let me examine the actual file to understand the URL template and hash retrieval mechanism:
<function_calls>
#!/bin/bashRead the full bucket/graalvm25.json file to understand context
cat bucket/graalvm25.json
</function_calls>
Closes #XXXX
Relates to #XXXX
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.