Skip to content

Conversation

@jackkke
Copy link

@jackkke jackkke commented Nov 28, 2025

Closes #XXXX

Relates to #XXXX

Summary by CodeRabbit

  • New Features
    • Added GraalVM Community Edition 25.0.1 (Windows x64) package with automatic update configuration.
    • Installer now configures runtime environment variables and PATH so the JDK is ready to use after installation.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 28, 2025

Walkthrough

Adds a new Scoop manifest file bucket/graalvm25.json for GraalVM Community Edition 25.0.1 (Windows x64) including download metadata, SHA-256, pre-install directory normalization, PATH/JAVA_HOME/GRAALVM_HOME exports, and autoupdate/checkver configuration.

Changes

Cohort / File(s) Change Summary
New GraalVM Scoop Manifest
bucket/graalvm25.json
New manifest for GraalVM 25.0.1: metadata (description, version, homepage, license), download URL and SHA-256, pre_install PowerShell steps to normalize extracted layout, adds bin to PATH, exports JAVA_HOME and GRAALVM_HOME, and includes checkver/autoupdate configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify JSON manifest syntax and schema compliance
  • Confirm download URL and SHA-256 hash match the release
  • Review pre_install PowerShell logic for correct directory normalization and idempotence
  • Validate exported environment variables and PATH modifications
  • Check checkver/autoupdate patterns for correct version detection and update URLs

Suggested labels

review-needed

Suggested reviewers

  • se35710

Poem

🐇 I hopped a patch from branch to main,
A manifest snug for GraalVM's reign.
Paths set right, hashes in view,
Windows users, ready—go brew! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template boilerplate with placeholder issue references and no actual context about the changes, implementation details, or rationale for the new manifest. Replace placeholder text with meaningful description: explain what GraalVM 25 manifest is being added, reference the actual related issue number, and provide context for the package version and Windows x64 support.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Create graalvm25.json' directly and specifically describes the main change—adding a new Scoop manifest file for GraalVM 25.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88dee90 and 40ad1e2.

📒 Files selected for processing (1)
  • bucket/graalvm25.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/graalvm25.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

graalvm25

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 33ad86a and 88dee90.

📒 Files selected for processing (1)
  • bucket/graalvm25.json (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull Requests
bucket/graalvm25.json

[error] 1-1: Checkver: Version check failed for graalvm25.json. Could not match latest GraalVM version pattern on downloads page; autoupdate skipped.

🔇 Additional comments (3)
bucket/graalvm25.json (3)

8-11: Verify pre_install script handles all extraction scenarios correctly.

The pre_install PowerShell script normalizes the extracted directory structure by detecting a single nested folder and moving its contents to the parent. Verify this handles the GraalVM 25.0.1 Windows distribution correctly.

Please confirm:

  • The GraalVM Community Edition Windows x64 release actually extracts to a nested directory (e.g., graalvm-community-jdk-25.0.1/)
  • The script logic is compatible with PowerShell versions available on target Windows systems

If the extraction behavior differs or the script logic needs refinement, adjust accordingly.


1-27: Verify manifest structure aligns with other Java manifests in the repository.

This is a new manifest for GraalVM. Ensure the structure, naming conventions, and configuration patterns align with existing Java/JDK manifests in the ScoopInstaller/Java bucket to maintain consistency.

Review similar manifests (e.g., graalvm*.json, openjdk*.json, or other JVM distributions) to confirm:

  • License field format and value are consistent
  • Environment variable setup matches precedent
  • checkver and autoupdate patterns follow established conventions
  • Pre_install logic is appropriate for this distribution type

6-7: I'll help you verify the download URL and hash integrity for this GraalVM 25 entry. Let me start by testing the URL accessibility and examining the file context.
<function_calls>

#!/bin/bash

Test main download URL accessibility

echo "=== Testing main download URL ==="
curl -sI 'https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-25.0.1/graalvm-community-jdk-25.0.1_windows-x64_bin.zip' | head -1

Test SHA-256 file availability

echo -e "\n=== Testing SHA-256 file URL ==="
curl -sI 'https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-25.0.1/graalvm-community-jdk-25.0.1_windows-x64_bin.zip.sha256' | head -1


</function_calls>

Now let me examine the actual file to understand the URL template and hash retrieval mechanism:
<function_calls>

#!/bin/bash

Read the full bucket/graalvm25.json file to understand context

cat bucket/graalvm25.json


</function_calls>

@jackkke jackkke closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant