feat: typed API responses + sync/async fix#10
Merged
VinciGit00 merged 2 commits intomainfrom Feb 17, 2026
Merged
Conversation
Replace ApiResult<unknown> with proper response types for all endpoints. Only crawl uses polling now — all other endpoints are direct POST calls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FrancescoSaverioZuppichini
force-pushed
the
feat/typed-api-responses
branch
from
f40c5f9 to
6f1e0a2
Compare
FrancescoSaverioZuppichini
assigned
FrancescoSaverioZuppichini and
VinciGit00 and unassigned
FrancescoSaverioZuppichini
VinciGit00
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApiResult<unknown>with proper response types (SmartScraperResponse,SearchScraperResponse,MarkdownifyResponse,CrawlResponse,ScrapeResponse,AgenticScraperResponse,GenerateSchemaResponse,SitemapResponse,CreditsResponse,HealthResponse,HistoryResponse)crawlactually needs polling. SwitchedsmartScraper,searchScraper,markdownify,scrape,agenticScraper,generateSchemafromsubmitAndPollto directrequest()callsonPollparams from all non-polling functions and their command callersgetTimeoutMs(), extractedisDone()helper, simplifiedPollResponsetypeTest plan
bun test)tsc --noEmitcleansmartScrapertocrawlwhere they belongbun run build)🤖 Generated with Claude Code