Add function for custom format + tests#9
Open
gmuraru wants to merge 3 commits intoSebiSebi:masterfrom
Open
Conversation
Author
|
@SebiSebi you still want to offer support for Python2? |
3c791d6 to
5f56b18
Compare
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 98.87% 98.98% +0.11%
==========================================
Files 5 5
Lines 89 99 +10
Branches 5 5
==========================================
+ Hits 88 98 +10
Partials 1 1
Continue to review full report at Codecov.
|
5f56b18 to
c8cf4e2
Compare
Author
|
Now it should work also for Python 2.7, but maybe it is a good idea to not provide back compatibility anymore since Python2 is dead :( |
03724c8 to
ff40023
Compare
ff40023 to
3d07cc7
Compare
|
Wondering if this PR will ever be approved? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
Change List:
set_fmtfunction to thesimpleandcoloredlogger such to set custom formats for the output log messagesimpleandcoloredlogger for testing the functionality