return GSPGroup while reverse-geocoding to GSP
#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
JamieTaylor-TUOS
requested changes
Sep 29, 2025
| ) | ||
| joined.update(nearest, overwrite=False) | ||
| joined["region_id"] = joined["region_id"].where(pd.notna(joined["region_id"]), None) | ||
| if "GSPGroup" in joined.columns: |
Contributor
There was a problem hiding this comment.
Not sure what the if condition is for? won't this always evaluate to True?
Contributor
Author
There was a problem hiding this comment.
This won't be True when reverse geo-coding llsoa and nuts
Comment on lines
+285
to
286
| return list(zip(joined["region_id"], joined["GSPGroup"])) | ||
| return joined["region_id"].tolist() |
Contributor
There was a problem hiding this comment.
I don't think its desirable to sometime return a list of strings and other times to return a list of tuples. I think we should always return a list of tuples, or else introduce a parameter to determine whether to return the GSPGroup or not (though the latter smells a little)
Contributor
Author
There was a problem hiding this comment.
Since llsoa and nuts doesn't need to return a list of tuples, I think we should come up with something else. Is it okay to make a separate function for reverse geo-coding gsp?
Co-authored-by: Jamie Taylor <jamie.taylor@sheffield.ac.uk>
Contributor
Author
|
Any idea why these tests are failing @JamieTaylor-TUOS ? (geocode) ph1ho@phy13076:~/Documents/Geocode$ git checkout 61-return-gsps-and-gspgroups-after-reverse-geocoding
Switched to branch '61-return-gsps-and-gspgroups-after-reverse-geocoding'
Your branch is up-to-date with 'origin/61-return-gsps-and-gspgroups-after-reverse-geocoding'.
(geocode) ph1ho@phy13076:~/Documents/Geocode$ pytest Tests/
=================================================================================== test session starts ====================================================================================
platform linux -- Python 3.10.12, pytest-8.3.4, pluggy-1.5.0
rootdir: /home/ph1ho/Documents/Geocode
plugins: requests-mock-1.11.0, anyio-4.8.0, cov-6.0.0, mock-3.14.0
collected 9 items
Tests/test_geocode.py ......... [100%]
===================================================================================== warnings summary =====================================================================================
Tests/test_geocode.py::geocodeTestCase::test_geocode_postcode
/home/ph1ho/Documents/Geocode/geocode/cpo.py:163: FutureWarning: The provided callable <function nanmean at 0x77a1d6351e10> is currently using SeriesGroupBy.mean. In a future version of pandas, the provided callable will be used directly. To keep current behavior pass the string "mean" instead.
results_.groupby("id")
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
========================================================================= 9 passed, 1 warning in 126.35s (0:02:06) =========================================================================
(geocode) ph1ho@phy13076:~/Documents/Geocode$ python3 --version
Python 3.13.2
|
JamieTaylor-TUOS
approved these changes
Oct 20, 2025
Herald-TUOS
deleted the
61-return-gsps-and-gspgroups-after-reverse-geocoding
branch
Herald-TUOS
restored the
61-return-gsps-and-gspgroups-after-reverse-geocoding
branch
Herald-TUOS
deleted the
61-return-gsps-and-gspgroups-after-reverse-geocoding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.