Fix buffer overflow by only using snprintf #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling from vinted#17:
This piece of code contains a buffer overflow issue because it uses a combination of
memcpyandsnprintfcalls that don't take the remaining buffer capacity into account.I've used the approach used on line 97 which uses a single
snprintfcall to make sure we don't overrun the buffer.Without the patch, CI fails with the following crash: