-
Notifications
You must be signed in to change notification settings - Fork 5
Enable Modular GC on v3.4.7 #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexaCampusano
wants to merge
1
commit into
main
Choose a base branch
from
nc/ruby-3.4-modgc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+29
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Build a Ruby version with modular GC support | ||
| # Built from Shopify/ruby fork at the commit corresponding to upstream ruby/ruby v3.4.7 tag. | ||
| # Upstream tag: https://github.com/ruby/ruby/releases/tag/ | ||
| # Commit: 7482835d0b5c9f55662fb7c6586f456354e2b66e | ||
| # | ||
| # This build enables Ruby's experimental modular GC feature, allowing | ||
| # alternative GC implementations to be loaded at runtime. | ||
| # | ||
| # MODULAR GC USAGE: | ||
| # Ruby is usable as normal in this build, it will use the default Ruby garbage | ||
| # collector and behave as expected. | ||
| # | ||
| # To use a modular GC, you need a GC compiled as a shared object with the name | ||
| # librubygc.<name>.so in the modular GC directory ($PREFIX/lib/ruby/gc/). | ||
| # | ||
| # Load it at runtime with: | ||
| # RUBY_GC_LIBRARY=<name> ruby | ||
| # | ||
|
|
||
| build_package_modular_gc_install() { | ||
| log_info "Building modular GC (default)..." | ||
| capture_command make install-modular-gc MODULAR_GC=default | ||
| } | ||
|
|
||
| package_option ruby configure --with-modular-gc="$PREFIX_PATH/lib/ruby/gc" | ||
|
|
||
| install_package "openssl-3.4.0" "https://github.com/openssl/openssl/releases/download/openssl-3.4.0/openssl-3.4.0.tar.gz#e15dda82fe2fe8139dc2ac21a36d4ca01d5313c75f99f46c4e8a27571b5486cd" openssl --if needs_openssl:1.0.2-3.x.x | ||
| install_git "ruby-3.4.7-modgc" "https://github.com/Shopify/ruby.git" "v3.4.7-pshopify1" autoconf enable_shared standard modular_gc_install | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The standard ruby-build definitions are still using OpenSSL 3.0.18, while the recent Shopify 3.4.x builds are using OpenSSL 3.1.4. And the latest OpenSSL 3.4.x build is 3.4.4. Out of curiosity, why are we going with 3.4.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we used #70 as reference. We can update this to 3.1.4 to keep in line with the other 3.4 builds.